Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create redux logic for storing token settings - closes #1948 #1964

Merged
merged 3 commits into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@osvaldovega
Copy link
Contributor

commented Apr 25, 2019

What issue have I solved?

-- #1948

How have I implemented/fixed it?

Update the settings reducer file adding one more field token in the same way as the mobile team has it, then add a function that will help to validate and update the active token based on the incoming data.

In the other hand I update the actions/settings.js file for add the a new action creator that will be on charge to update the token of the settings reducer

How has this been tested?

Right now there is only logic for this functionality and not something that can be trigger from the UI so that way I tested was triggering/dispatching the settingsUpdateToken action with data and see if the reducer state update based on that.

data = {
        token: {
          active: 'LSK',
          list: {
            LSK: true,
            BTC: true,
          },
        },
      };

You can change the active value from LSK to BTC and see how the active token now change.

Review checklist

@osvaldovega osvaldovega self-assigned this Apr 25, 2019

@osvaldovega osvaldovega added this to Pull Requests in Not used anymore via automation Apr 25, 2019

@osvaldovega osvaldovega requested a review from slaweet Apr 25, 2019

@slaweet slaweet removed this from Pull Requests in Not used anymore Apr 26, 2019

slaweet added some commits Apr 26, 2019

@slaweet
Copy link
Member

left a comment

Thank you, Osvaldo 👍

@slaweet slaweet added the ready label Apr 26, 2019

@osvaldovega osvaldovega merged commit cc771c4 into development Apr 26, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@osvaldovega osvaldovega deleted the 1947-redux-logic-for-storing-token-settings branch Apr 26, 2019

@osvaldovega osvaldovega changed the title Implement redux logic for switching active token - closes #1948 Create redux logic for storing token settings - closes #1948 Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.