Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement storing BTC account data - Closes #1887 #1977

Merged
merged 42 commits into from May 9, 2019
Merged

Implement storing BTC account data - Closes #1887 #1977

merged 42 commits into from May 9, 2019

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented May 2, 2019

What issue have I solved?

#1887

How have I implemented/fixed it?

Work in progress

How has this been tested?

Review checklist

@slaweet slaweet self-assigned this May 2, 2019
slaweet added 18 commits May 2, 2019 16:40
@slaweet
✅ Update search api tests to new account api
8246048
@slaweet
✅ Update account api imports in tests
7c2febe
@slaweet
✅ Update tests to work with updated getAccount api util
4795626
@slaweet
✅ Skip failing peers unit test
5df8036 
because it will be removed soon anyway
@slaweet
✅ Create unit test for generic account api util
0a7e539
@slaweet
✅ Ignore peers actions test coverage
ef69962 
because they should be removed soon
@slaweet
♻️ Move login action to account actions
f361b5d
@slaweet
🌱 Update BTC account utils to use network config
ac68c91
@slaweet
🌱 Update login action to fetch BTC account
350bc38
@slaweet
🌱 Update topBar to show BTC balance
f30c513
@slaweet
♻️ Move lisk address extraction out of login action
8d925cb
@slaweet
♻️ Move the condition if login back to setActivePeer
100540c
@slaweet
✅ Update topBar test to new account structure
6f9c73a
@slaweet
✅ Create test for login action
8bc9c2a
@slaweet
♻️ refactor duplicated error messages
d5a9241
@slaweet
✅ Fix test coverage of account actions
46abd2f
@slaweet
🐛 Add missing import to peers actions
4e82735
@slaweet
🌱 Add token key to getAccount response
0fb0754
@slaweet slaweet changed the base branch from 1945-storing-btc-transactions to development May 8, 2019 09:55
@slaweet slaweet marked this pull request as ready for review May 8, 2019 13:45
@slaweet slaweet requested a review from massao May 8, 2019 14:59
massao
massao approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@massao massao added the ready label May 9, 2019
@slaweet slaweet merged commit 6364b67 into development May 9, 2019
@slaweet slaweet deleted the 1887-storing-btc-account branch May 9, 2019 09:19
@eniolam1000752 eniolam1000752 mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massao massao massao approved these changes

Assignees

@slaweet slaweet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slaweet @massao