Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup electron builder actions #5404

Merged
merged 25 commits into from
Nov 3, 2023
Merged

Setup electron builder actions #5404

merged 25 commits into from
Nov 3, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Oct 25, 2023 •
edited by ManuGowda
Loading

What was the problem?

This PR resolves #5400

How was it solved?

  • Create work flow file for electron-build
  • Test and confirm release artifacts are correctly working and are installable on the different distributions.

How was it tested?

@eniolam1000752 eniolam1000752 self-assigned this Oct 25, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ManuGowda ManuGowda force-pushed the 1977-setup-electron-builder-actions branch from f4dd854 to b13fea7 Compare November 1, 2023 14:11
@ManuGowda ManuGowda force-pushed the 1977-setup-electron-builder-actions branch from b13fea7 to 91963e5 Compare November 1, 2023 14:18
@ManuGowda ManuGowda force-pushed the 1977-setup-electron-builder-actions branch from 715c0be to 98c3cc5 Compare November 1, 2023 14:46
oskarleonard
oskarleonard previously approved these changes Nov 1, 2023
View reviewed changes
eniolam1000752
eniolam1000752 commented Nov 3, 2023
View reviewed changes
Copy link
Contributor Author

@eniolam1000752 eniolam1000752 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can't approve because I created the PR 😅

@ManuGowda ManuGowda merged commit 7587449 into release/3.0.0 Nov 3, 2023
6 checks passed
@ManuGowda ManuGowda deleted the 1977-setup-electron-builder-actions branch November 3, 2023 13:11
@ManuGowda ManuGowda restored the 1977-setup-electron-builder-actions branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 1977-setup-electron-builder-actions branch November 27, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikem-legend ikem-legend ikem-legend approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

@Nazgolze Nazgolze Awaiting requested review from Nazgolze

@abhishekjalan87 abhishekjalan87 Awaiting requested review from abhishekjalan87

@oskarleonard oskarleonard Awaiting requested review from oskarleonard

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eniolam1000752 @CLAassistant @ManuGowda @oskarleonard @ikem-legend @abhishekjalan87 @RukayatSalami @mohammadmoaddab