Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest the user to use bioAuth after the first successful sign-in - Closes #284 #291

Merged
merged 10 commits into from Oct 17, 2018

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Oct 17, 2018

What was the bug or feature?

Described in #284

How did I fix it?

  • It'll suggest only the first time the user signs in.
  • It'll bio-auth the users before letting them activate the bio-auth methods.
  • If the user cancels any of the prompts at any stage, the bio-auth methods won't be activated and the user will be directly signed in.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Note:
This PR doesn't implement the bioAuth dialog in Android since this will be addressed by #290 .

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@reyraa reyraa self-assigned this Oct 17, 2018
@reyraa reyraa added this to Pull Requests in Version 0.4.0 via automation Oct 17, 2018
Copy link
Contributor

@yasharAyari yasharAyari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@reyraa reyraa merged commit 9fac9f8 into development Oct 17, 2018
Version 0.4.0 automation moved this from Pull Requests to Merged Pull Requests Oct 17, 2018
@reyraa reyraa deleted the 284-suggest-bio-auth branch October 17, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 0.4.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

3 participants