Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Month names are not translated in Deutsch - Closes #929 #942

Merged
merged 1 commit into from Aug 15, 2019
Merged

i18n: Month names are not translated in Deutsch - Closes #929 #942

merged 1 commit into from Aug 15, 2019

Conversation

colado
Copy link
Contributor

@colado colado commented Aug 14, 2019

What was the bug or feature?

Described in #929.

How did I fix it?

Localized the month formatting using moment.js.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How to test it?

Check that dates on transactions are localized correctly on Home.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@colado colado requested review from reyraa and massao August 14, 2019 13:12
@colado colado self-assigned this Aug 14, 2019
@colado colado added this to Pull Requests in Version 1.3.0 via automation Aug 14, 2019
@colado colado removed this from Pull Requests in Version 1.3.0 Aug 14, 2019
massao
massao approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@colado colado merged commit c66e2d3 into development Aug 15, 2019
@reyraa reyraa deleted the 929-month-names-german branch September 11, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massao massao massao approved these changes

@reyraa reyraa Awaiting requested review from reyraa

Assignees

@colado colado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colado @massao @karmacoma