Remove access to 'Register as delegate' form for delegates

[ginacontrino]

Expected behaviour

A delegate should not be able to see the "Register as delegate" form

Actual behaviour

If a delegate visits main/voting/register-delegate the form pops up

Steps to reproduce

• Log in as a delegate
• Go to http://localhost:8080/#/main/voting/register-delegate

[joerodrig]

I would like to help with this. Are there any resources showing a way to simulate the delegate account state and coins?

[joerodrig]

@ginacontrino It appears that this form disables the "register" button if the account is already a delegate. See registerDelegate.js - line 70. Could this be the expected behavior and there just aren't specs written for that case? That check shouldn't be necessary if the form shouldn't appear if the user is a delegate.

[ginacontrino]

@joerodrig Hey, yes that's correct. The button is correctly disabled, because in this case, the user is already a delegate. In general, they shouldn't be able to access this form at all though, so it's better to instead display a message that informs the user about why they can't visit the route 'main/voting/register-delegate'. A test that checks that the error message is displayed, would be nice of course :)