This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Migrate browsing delegates on Voting tab to React - Closes #350 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
reviewed
Jul 25, 2017
| <TableCell numeric>Vote</TableCell> | ||
| <TableCell numeric>Rank</TableCell> | ||
| <TableCell numeric>Name</TableCell> | ||
| <TableCell numeric>Uptime</TableCell> |
There was a problem hiding this comment.
This column should be 'Lisk Address'
slaweet
reviewed
Jul 25, 2017
| return ( | ||
| <div className="box"> | ||
| <VotingHeader search={ value => this.search(value) }></VotingHeader> | ||
| <Table className={styles.table} |
There was a problem hiding this comment.
The table should spread the whole width of the containing card. Especially selected rows look bad. The same thing was solved In Forged Blocks: https://github.com/LiskHQ/lisk-nano/blob/development/src/components/forging/forgedBlocks.js#L16
reyraa
previously approved these changes
Jul 27, 2017
slaweet
reviewed
Jul 27, 2017
| <TableCell>{item.productivity} %</TableCell> | ||
| <TableCell>{item.approval} %</TableCell> | ||
| </TableRow> | ||
| ))} |
There was a problem hiding this comment.
There should be a No delegates found message here if the search result is empty.
reyraa
approved these changes
Jul 27, 2017
karmacoma
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #350