This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Setup React toaster - Closes #486 #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
suggested changes
Aug 1, 2017
src/actions/toaster.js
Outdated
| * An action to dispatch to hide a toast | ||
| * | ||
| */ | ||
| export const toastHidden = () => ({ |
There was a problem hiding this comment.
This doesn't handle multiple toast. we're using toasts to notify user about many changes, like sign message and network status changes. There's a good chance we'll need to show multiple - 2 is more realistic - toasts at the same time.
Please change this to include id and tweak other parts of code accordingly.
thanks
There was a problem hiding this comment.
Toasts are by material design specs limited to one.
"They should not be persistent or be stacked, as they are above other elements on screen."
http://www.google.com/design/spec/components/snackbars-toasts.html#snackbars-toasts-usage
In Angular Material, it wasn't possible to stack them either.
reyraa
approved these changes
Aug 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #486
But not using
react-redux-toaser.Instead, using http://react-toolbox.com/#/components/snackbar because we are already using react toolbox so there's no point in adding another library.