This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Convert i18n-scanner command into a webpack plugin - Closes #831 #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
831-i18n-scanner-in-webpack
branch
from
d33a5ed
to
abea5a2
Compare
reyraa
suggested changes
Nov 6, 2017
src/i18n-scanner.js
Outdated
| const content = fs.readFileSync(file, 'utf-8'); | ||
| parser.parseFuncFromString(content, { list: translationFunctionNames }, customHandler); | ||
| }); | ||
| class HelloWorldPlugin { |
There was a problem hiding this comment.
Hello world plugin? please rename to a more relevant name.
reyraa
approved these changes
Nov 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We had to generate i18n source file manually by
npm run i18n-scanner, so we often forgot to do it and had missing sources.How did I fix it?
By creating a webpack plugin that runs when the react app is built.
How to test it?
npm run devprops.t(...)src/locales/en/common.jsonwas updatedReview checklist