This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Fail on failed blockchain download - Closes #32 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could set pipefail (for this part of the code) |
Nazgolze
force-pushed
the
32-restore-fail
branch
from
cb519f2
to
7ebc7f9
Compare
fchavant
previously requested changes
Oct 19, 2018
packaged/lisk.sh
Outdated
| @@ -337,7 +339,7 @@ check_pid() { | |||
| } | |||
|
|
|||
| lisk() { | |||
| node "$(pwd)/bin/lisk" | |||
| node "$PWD/bin/lisky" | |||
There was a problem hiding this comment.
Commander's binary is called lisk
* Improve initial cd * Also s/[$](pwd)/$PWD/g Pipefail around gunzip (lisk.sh isn't ready for anything resembling strict mode just yet) Change checkmarks to +'s Change $USER = root check to $UID = 0 check
Nazgolze
force-pushed
the
32-restore-fail
branch
from
7ebc7f9
to
263e732
Compare
|
The plus signs are a little confusing when using |
Which presented the opportunity to make X -> [-]
fchavant
changed the title
fchavant
approved these changes
Oct 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Well, this covers the example in the issue where it fails to download.
If psql fails, that should be caught. If gunzip fails, if psql somehow succeeds, that will still register as a success as pipefail isn't set