Merge pull request #1161 from LiskHQ/1158-fix_recipientId_validation

Change recipientId to accept null - Closes #1158
LiskHQ · Mar 4, 2019 · 0845f16 · 0845f16
2 parents 5250dca + c3d611f
commit 0845f16
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/lisk-transactions/src/base_transaction.ts b/packages/lisk-transactions/src/base_transaction.ts
@@ -151,7 +151,7 @@ export abstract class BaseTransaction {
 		this.amount = new BigNum(rawTransaction.amount);
 		this.fee = new BigNum(rawTransaction.fee);
 		this._id = rawTransaction.id;
-		this.recipientId = rawTransaction.recipientId;
+		this.recipientId = rawTransaction.recipientId || '';
 		this.recipientPublicKey = rawTransaction.recipientPublicKey || '';
 		this.senderId =
 			rawTransaction.senderId ||

diff --git a/packages/lisk-transactions/src/transaction_types.ts b/packages/lisk-transactions/src/transaction_types.ts
@@ -38,7 +38,7 @@ export interface TransactionJSON {
 	readonly asset: object;
 	readonly fee: string | number;
 	readonly id?: string;
-	readonly recipientId: string;
+	readonly recipientId: string | null;
 	readonly recipientPublicKey?: string;
 	readonly senderId?: string;
 	readonly senderPublicKey: string;

diff --git a/packages/lisk-transactions/src/utils/validation/schema.ts b/packages/lisk-transactions/src/utils/validation/schema.ts
@@ -39,7 +39,7 @@ export const transaction = {
 			type: 'string',
 		},
 		recipientId: {
-			type: 'string',
+			type: ['string', 'null'],
 		},
 		recipientPublicKey: {
 			type: ['string', 'null'],