Pass the caught error to the callback

LiskHQ · Jul 13, 2020 · 593e74b · 593e74b
1 parent f610afa
commit 593e74b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts b/framework-plugins/lisk-framework-http-api-plugin/src/controllers/peers.ts
@@ -83,6 +83,6 @@ export const getPeers = (channel: BaseChannel) => async (
 
 		res.status(200).send(peers);
 	} catch (err) {
-		next();
+		next(err);
 	}
 };
diff --git a/framework-plugins/lisk-framework-http-api-plugin/test/functional/peers.spec.ts b/framework-plugins/lisk-framework-http-api-plugin/test/functional/peers.spec.ts
@@ -64,6 +64,25 @@ describe('Peers endpoint', () => {
 			expect(status).toBe(200);
 		});
 
+		it('should throw 500 error when channel.invoke fails', async () => {
+			// Arrange
+			app['_channel'].invoke = jest.fn();
+			// Mock channel invoke only when app:getConnectedPeers is called
+			when(app['_channel'].invoke)
+				.calledWith('app:getConnectedPeers')
+				.mockRejectedValue(new Error('test') as never);
+			const { response, status } = await callNetwork(axios.get(getURL('/api/peers')));
+			// Assert
+			expect(status).toBe(500);
+			expect(response).toEqual({
+				errors: [
+					{
+						message: 'test',
+					},
+				],
+			});
+		});
+
 		it('should respond with 400 and error message when passed incorrect state value', async () => {
 			const { response, status } = await callNetwork(axios.get(getURL('/api/peers?state=xxx')));
 			// Assert