Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove unwanted old database functions #2954

Closed
ManuGowda opened this issue Feb 25, 2019 · 1 comment
Closed

Remove unwanted old database functions #2954

ManuGowda opened this issue Feb 25, 2019 · 1 comment
Assignees
Milestone

Comments

@ManuGowda
Copy link
Contributor

ManuGowda commented Feb 25, 2019

Expected behavior

Remove unwanted old database related logic which is no longer required after storage changes.

Actual behavior

There are few old database logic functions such as
https://github.com/LiskHQ/lisk/blob/ebfc1349419c6263c26b6c6d59cff7b97223e90f/framework/src/modules/chain/logic/transaction.js#L1221

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

Grooming Meeting Notes
Remove dbRead and storageRead and put it in other blocks logic related file or merge the code.

@lsilvs
Copy link
Contributor

lsilvs commented Feb 25, 2019

It can only be done after #2424 as modules.blocks.process.loadBlocksFromPeer still uses it.

REF.: #2424 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants