Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Move chain helper slots to chain logic #3070

Closed
diego-G opened this issue Mar 14, 2019 · 1 comment
Closed

Move chain helper slots to chain logic #3070

diego-G opened this issue Mar 14, 2019 · 1 comment
Labels
framework type: refactoring

Comments

@diego-G
Copy link

diego-G commented Mar 14, 2019 •
edited

Expected behavior

Chain helpers folder should contain only real utils without business logic.

Actual behavior

Chain helper Slots contains core logic of the application. Therefore It should be move to logic folder.

Which version(s) does this affect? (Environment, OS, etc...)

1.6
@diego-G diego-G self-assigned this Mar 14, 2019
@diego-G diego-G mentioned this issue Mar 14, 2019
Merged
@shuse2 shuse2 removed the *medium label Apr 15, 2019
@shuse2
Copy link
Collaborator

shuse2 commented May 28, 2019

Superseded by #3616

@shuse2 shuse2 closed this as completed May 28, 2019
This was referenced Jan 2, 2024
Open
Open
This was referenced Mar 15, 2024
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
framework type: refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diego-G @shuse2