Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Combine all the block related logic into one module and expose used functionality #3616

Closed
shuse2 opened this issue May 14, 2019 · 0 comments · Fixed by #3679
Closed

Combine all the block related logic into one module and expose used functionality #3616

shuse2 opened this issue May 14, 2019 · 0 comments · Fixed by #3679
Assignees
@lsilvs
Labels
type: refactoring

Comments

@shuse2
Copy link
Collaborator

shuse2 commented May 14, 2019 •
edited
Loading

Expected behavior

Within blocks module, it should not have dependency to transport, forge, loader, and no internal circular dependency.

  • blocks/
  • blocks.js
  • block_reward.js
  • block.js
  • block_version.js
  • block_slots.js

Actual behavior

It has circular dependency within the modules and using upper layer modules
@shuse2 shuse2 changed the title Combine all the transaction related logic into one module and expose used functionality Combine all the block related logic into one module and expose used functionality May 14, 2019
@shuse2 shuse2 mentioned this issue May 21, 2019
Merged
This was referenced May 28, 2019
Closed
Closed
Closed
Closed
shuse2 added a commit that referenced this issue May 29, 2019
@shuse2
Merge pull request #3679 from LiskHQ/3616-refactor_blocks
b43b8c2 
Refactor blocks related modules not to have circular dependency - Closes #3616
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lsilvs lsilvs

Labels
type: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor blocks related modules not to have circular dependency - Closes #3616 LiskArchive/lisk-sdk
2 participants
@lsilvs @shuse2