Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove invokeAsync() from controller and bus #3198

Closed
diego-G opened this issue Mar 27, 2019 · 1 comment
Closed

Remove invokeAsync() from controller and bus #3198

diego-G opened this issue Mar 27, 2019 · 1 comment

Comments

@diego-G
Copy link

diego-G commented Mar 27, 2019

Expected behavior

All the communications in the bus are asynchronous.

Actual behavior

Chain module contains synchronous code that produces a too big cascade refactoring if we convert them to async. We have introduced and invokAsync method in controller and bus to work it out until we refactor the codebase introducing the new P2P library. Therefore these temporary methods have to be removed when network module manages all the P2P related actions.

For referene, here it is the commit with the affected code: ef925e6

Which version(s) does this affect? (Environment, OS, etc...)

2.0

@diego-G
Copy link
Author

diego-G commented Mar 28, 2019

Close by 5dbcda8 which is the right direction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant