Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Rename application controller identifier "lisk" to "app" #3208

Closed
nazarhussain opened this issue Mar 27, 2019 · 0 comments · Fixed by #3258
Closed

Rename application controller identifier "lisk" to "app" #3208

nazarhussain opened this issue Mar 27, 2019 · 0 comments · Fixed by #3258

Comments

@nazarhussain
Copy link
Contributor

Currently we are using a identifier lisk to specify the channel for application controller. Which in our case seems correct as we call our application lisk. But to align with custom application development, we should choose something more generic.

I suggest that we rather use app identifier for application controller. So who ever develop application with our sdk, can use this generic but more aligned identifier.

https://github.com/LiskHQ/lisk/blob/8f7ac1ce66e16616ecd38b7880d424630508b9ae/framework/src/controller/controller.js#L128

To clarify further, we are using above in a way channel.subscribe('lisk:ready', cb). In our case it seems correct but if someone develop another custom token and still use lisk identifier in code that will be confusing. So rather channel.subscribe('app:ready', cb) will be more clear and understandable.

@nazarhussain nazarhussain changed the title Rename lisk identifier to app Rename application controller identifier "lisk" to "app" Mar 27, 2019
@2snEM6 2snEM6 self-assigned this Apr 4, 2019
shuse2 added a commit that referenced this issue Apr 8, 2019
…er_ID_to_app

Rename 'lisk' to 'app' ID for controller - Closes #3208
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants