Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review prettier setting for overall SDK structure #3401

Closed
shuse2 opened this issue Apr 17, 2019 · 0 comments
Closed

Review prettier setting for overall SDK structure #3401

shuse2 opened this issue Apr 17, 2019 · 0 comments
Assignees
@yatki
Milestone
Improve Lisk Fram...

Comments

@shuse2
Copy link
Member

shuse2 commented Apr 17, 2019

Expected behavior

Prettier should be applied to all of the files, and it should be consistent.

Actual behavior

When we apply the prettier, some changes come up.
Also, there are different prettier setting in framework compare to other place

Steps to reproduce

npm run format

Which version(s) does this affect? (Environment, OS, etc...)
@shuse2 shuse2 mentioned this issue Apr 17, 2019
Closed
3 tasks
@yatki yatki mentioned this issue Apr 30, 2019
Merged
3 tasks
shuse2 added a commit that referenced this issue May 2, 2019
@shuse2
Merge pull request #3487 from LiskHQ/3401-review-prettier
32950c9 
Review prettier setting for overall SDK structure - Closes #3401
@shuse2 shuse2 closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yatki yatki

Labels
None yet
Projects
None yet
Milestone
Improve Lisk Framework UX - Phase 2
Development

No branches or pull requests
2 participants
@shuse2 @yatki