Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a default implementation of the prepare step in BaseTransaction #3730

Closed
MaciejBaj opened this issue May 27, 2019 · 0 comments
Closed

Provide a default implementation of the prepare step in BaseTransaction #3730

MaciejBaj opened this issue May 27, 2019 · 0 comments
Assignees
@MaciejBaj
Labels
elements/transactions type: refactoring
Milestone
Reduce technical ...

Comments

@MaciejBaj
Copy link
Contributor

Expected behavior

prepare is not obligatory to implement in all of the transactions extending BaseTransction. The default implementation returns the sender's account.

Actual behavior

Every transaction extending the BaseTransction needs to implement the prepare step.

Which version(s) does this affect? (Environment, OS, etc...)

2.0.0
@MaciejBaj MaciejBaj self-assigned this May 27, 2019
@MaciejBaj MaciejBaj mentioned this issue May 29, 2019
Merged
@MaciejBaj MaciejBaj added this to the Sprint One milestone Jun 12, 2019
shuse2 added a commit that referenced this issue Jun 17, 2019
@shuse2
Merge pull request #3744 from LiskHQ/3730-default_prepare_in_base_trs
64b459f 
Provide a default implementation of the prepare step in BaseTransaction - Closes #3730
@shuse2 shuse2 closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaciejBaj MaciejBaj

Labels
elements/transactions type: refactoring
Projects
None yet
Milestone
Reduce technical debt
Development

No branches or pull requests
2 participants
@shuse2 @MaciejBaj