Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BaseTransaction validation in framework #3877

Closed
shuse2 opened this issue Jun 27, 2019 · 0 comments
Closed

Update BaseTransaction validation in framework #3877

shuse2 opened this issue Jun 27, 2019 · 0 comments

Comments

@shuse2
Copy link
Member

shuse2 commented Jun 27, 2019

Expected behavior

After #3821, framework will not have sufficient check for the BaseTransaction.
However, we need to make sure that it has executable transaction type when custom transaction is supplied.

Actual behavior

Currently it's too strict that it only allows exact same instance, and after the issue, it will allow anything and fail on runtime

Which version(s) does this affect? (Environment, OS, etc...)

2.1-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant