Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

P2P 2.3 incompatibility with 2.0 and 1.x related to peer lists #4060

Closed
jondubois opened this issue Aug 8, 2019 · 0 comments
Closed

P2P 2.3 incompatibility with 2.0 and 1.x related to peer lists #4060

jondubois opened this issue Aug 8, 2019 · 0 comments
Assignees
@ishantiw
Labels
type: bug

Comments

@jondubois
Copy link
Contributor

jondubois commented Aug 8, 2019 •
edited
Loading

Expected behavior

  • The 2.3 node should work with old 2.0 and 1.x peers.

Actual behavior

  • v2.3 nodes need to expose both the old list endpoint and the new getPeers (minimal) endpoints.
  • v2.3 nodes need to call the old list endpoint when trying to fetch peers from an old v2.0 or v1.x peer.
  • There is an incompatibility issue related to ipAddress vs ip properties in old versions.

Steps to reproduce

Try to connect a v2.3 node with old v2.0 and v1.6 nodes.

Which version(s) does this affect? (Environment, OS, etc...)

v2.3
@jondubois jondubois changed the title Support both getPeers and old list RPC for compatibility with old Lisk versions P2P 2.3 incompatibility with 2.0 and 1.x related to peer lists Aug 8, 2019
@ishantiw ishantiw mentioned this issue Aug 9, 2019
Merged
5 tasks
shuse2 added a commit that referenced this issue Aug 12, 2019
@shuse2
Merge pull request #4065 from LiskHQ/4060-p2p_2.3_incompatibility_wit…
452986f 
…h_older_version

P2P 2.3 incompatibility with older version - Closes #4060
@shuse2 shuse2 closed this as completed Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ishantiw ishantiw

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jondubois @shuse2 @ishantiw