Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Move transaction module in framework to inside of blocks module #4138

Closed
shuse2 opened this issue Aug 23, 2019 · 0 comments · Fixed by #4469
Closed

Move transaction module in framework to inside of blocks module #4138

shuse2 opened this issue Aug 23, 2019 · 0 comments · Fixed by #4469
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Aug 23, 2019

Description

Currently, transaction module is separated from blocks module, but it should be inside of blocks module like

/blocks
  index.js
  /transactions
    transaction_handler.js
    index.js

Additionally, interface_adapter is only used for transaction, so it also should be in the blocks module

Also, relevant functions which are used from upper layer need to be exported from the blocks module.

Motivation

Because blocks module is responsible for saving and applying the transaction, transaction module is sub-domain of the blocks module

Acceptance Criteria

  • All tests related to transactions module needs to be moved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant