Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

BFT compliance should not checked on detached block #4511

Closed
shuse2 opened this issue Nov 15, 2019 · 0 comments · Fixed by #4513
Closed

BFT compliance should not checked on detached block #4511

shuse2 opened this issue Nov 15, 2019 · 0 comments · Fixed by #4513
Assignees
@2snEM6
Labels
type: bug
Milestone
Sprint 10

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Nov 15, 2019

Expected behavior

Because when validating the detached block, a node might not have correct information about the delegate last forged height, it should not check the BFT compliance.

Actual behavior

It is checking the BFT compliance when checking the detached block.

Steps to reproduce

Sync with other blockchain and observe it will rejected by invalid reward

Which version(s) does this affect? (Environment, OS, etc...)
@shuse2 shuse2 added this to the Sprint 10 milestone Nov 15, 2019
@2snEM6 2snEM6 mentioned this issue Nov 15, 2019
Merged
5 tasks
shuse2 added a commit that referenced this issue Nov 18, 2019
@shuse2
Merge pull request #4513 from LiskHQ/fix_validate_detached
92dd8f1 
Remove BFT headers validation from validate detached - Closes #4511
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@2snEM6 2snEM6

Labels
type: bug
Projects
None yet
Milestone
Sprint 10
Development

Successfully merging a pull request may close this issue.

Remove BFT headers validation from validate detached - Closes #4511 LiskArchive/lisk-sdk
2 participants
@shuse2 @2snEM6