Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing unit tests coverage for Chain/Transport banning mechanism #4595

Closed
valamidev opened this issue Dec 4, 2019 · 0 comments · Fixed by #4603
Closed

Add missing unit tests coverage for Chain/Transport banning mechanism #4595

valamidev opened this issue Dec 4, 2019 · 0 comments · Fixed by #4603
Assignees
@valamidev
Milestone
Sprint 11

Comments

@valamidev
Copy link
Contributor

Description

  • Improve test coverage in Chain/Transport related to LIP-0004 Peer banning mechanism.

Acceptance Criteria

  • Have unit test coverage in Chain/Transport for every Peer banning scenario.

Additional Information
@valamidev valamidev self-assigned this Dec 4, 2019
@valamidev valamidev mentioned this issue Dec 5, 2019
Merged
5 tasks
ManuGowda added a commit that referenced this issue Dec 6, 2019
@ManuGowda
Merge pull request #4603 from LiskHQ/4595-unit-test-improvement-chain…
5745ecc 
…-transport

Improve Chain/Transport unit test coverage  - Closes #4595
diego-G pushed a commit to diego-G/lisk-sdk that referenced this issue Dec 12, 2019
@ManuGowda
Merge pull request LiskHQ#4603 from LiskHQ/4595-unit-test-improvement…
c2c6620 
…-chain-transport

Improve Chain/Transport unit test coverage  - Closes LiskHQ#4595
@sridharmeganathan sridharmeganathan added this to the Sprint 11 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valamidev valamidev

Labels
None yet
Projects
None yet
Milestone
Sprint 11
Development

Successfully merging a pull request may close this issue.

Improve Chain/Transport unit test coverage - Closes #4595 LiskHQ/lisk-sdk
2 participants
@sridharmeganathan @valamidev