Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer Banning is not executed correctly and related tests are outdated. #4789

Closed
valamidev opened this issue Feb 3, 2020 · 1 comment · Fixed by #4767
Closed

Peer Banning is not executed correctly and related tests are outdated. #4789

valamidev opened this issue Feb 3, 2020 · 1 comment · Fixed by #4767
Assignees
@valamidev
Labels
elements/P2P type: bug

Comments

@valamidev
Copy link
Contributor

Expected behavior

  • When EVENT_BAN_PEER event is emitted, it should add the banned Peer IPaddress into the related list (currently _peerBook.bannedIPs) and start a timer which refer to execute remove the ban when timer is finished.

Actual behavior

  • Peer Banning (via applyPenalty) only disconnect the Peer and existing test are not able to verify the difference.

Steps to reproduce

  • npm run test:functional -- actions/peer_banning.ts

Which version(s) does this affect? (Environment, OS, etc...)
@valamidev valamidev self-assigned this Feb 3, 2020
valamidev added a commit that referenced this issue Feb 3, 2020
@valamidev
🐛 Fix Peer Banning issue and add related tests
8ae80ad 
Fix issue #4789
@valamidev
Copy link
Contributor Author

Solved in #4767

@valamidev valamidev mentioned this issue Feb 3, 2020
Merged
5 tasks
@valamidev valamidev changed the title Peer Banning is not executed correctly and related test are outdated. Peer Banning is not executed correctly and related tests are outdated. Feb 3, 2020
shuse2 added a commit that referenced this issue Feb 7, 2020
@shuse2
Merge pull request #4767 from LiskHQ/4638-peerserver-implementation
5997714 
P2P add PeerServer class - Closes  #4638 & #4789
@shuse2 shuse2 linked a pull request Feb 7, 2020 that will close this issue
P2P add PeerServer class - Closes #4638 & #4789 #4767
Merged
5 tasks
@shuse2 shuse2 closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valamidev valamidev

Labels
elements/P2P type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

P2P add PeerServer class - Closes #4638 & #4789 LiskHQ/lisk-sdk
2 participants
@shuse2 @valamidev