Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update all protocol-specs to follow new address format #5335

Closed
nazarhussain opened this issue May 15, 2020 · 1 comment
Closed

Update all protocol-specs to follow new address format #5335

nazarhussain opened this issue May 15, 2020 · 1 comment
Assignees
@shuse2
Labels
protocol-spec type: bug
Milestone
Sprint 20

Comments

@nazarhussain
Copy link
Contributor

nazarhussain commented May 15, 2020 •
edited by ManuGowda
Loading

Expected behavior

All protocol-specs should use all address related attributes as 20 bytes hex format string.

Actual behavior

Currently, protocol-specs are using old address format ***L which is now removed from the SDK.

Acceptance Crieteria

  • There should be no ***L format address in any of output JSON files.
  • Remove unused protocol-specs
    • block_processing_xxx
    • transaction_signing

Additional Information

  • Use lisk-codec for creating protocol specs
@ManuGowda ManuGowda mentioned this issue May 15, 2020
Closed
@nazarhussain nazarhussain self-assigned this May 15, 2020
@nazarhussain nazarhussain mentioned this issue May 18, 2020
Merged
@sridharmeganathan sridharmeganathan added this to the Next Sprint milestone May 20, 2020
@nazarhussain
Copy link
Contributor Author

@shuse2 Assigning this task to you, as you can do it one go while updating the specs.

@nazarhussain nazarhussain assigned shuse2 and unassigned nazarhussain Jun 3, 2020
@shuse2 shuse2 mentioned this issue Jun 3, 2020
Merged
shuse2 added a commit that referenced this issue Jun 4, 2020
@shuse2
Merge pull request #5383 from LiskHQ/5368-update_transaction_test
e54474a 
Update transaction test using updated protocol-spec - Closes #5368, #5335 and #5209
@shuse2 shuse2 closed this as completed Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
protocol-spec type: bug
Projects
None yet
Milestone
Sprint 20
Development

No branches or pull requests
3 participants
@nazarhussain @shuse2 @sridharmeganathan