Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport.ts handleEventPostTransaction returns on error instead of throwing #5596

Closed
pablitovicente opened this issue Jul 29, 2020 · 0 comments · Fixed by #5597
Closed

transport.ts handleEventPostTransaction returns on error instead of throwing #5596

pablitovicente opened this issue Jul 29, 2020 · 0 comments · Fixed by #5597
Assignees
@pablitovicente
Labels
type: bug

Comments

@pablitovicente
Copy link
Contributor

Expected behavior

In transport.ts handleEventPostTransaction() throws errors.

Actual behavior

In transport.ts handleEventPostTransaction() returns object instead of throwing.

Steps to reproduce

use an action that uses handleEventPostTransaction causing an error

Which version(s) does this affect? (Environment, OS, etc...)

5.0
@pablitovicente pablitovicente self-assigned this Jul 29, 2020
@pablitovicente pablitovicente mentioned this issue Jul 29, 2020
Merged
shuse2 added a commit that referenced this issue Jul 30, 2020
@shuse2
Merge pull request #5597 from LiskHQ/5596-fix_transport_event_error_h…
dc0e5d1 
…andling

transport.ts handleEventPostTransaction returns on error instead of throwing - Closes #5596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablitovicente pablitovicente

Labels
type: bug
Projects
None yet
Milestone
No milestone
1 participant
@pablitovicente