Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add del on state store account #5631

Closed
shuse2 opened this issue Aug 7, 2020 · 0 comments · Fixed by #5669
Closed

Add del on state store account #5631

shuse2 opened this issue Aug 7, 2020 · 0 comments · Fixed by #5669
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Aug 7, 2020

Description

account state store should have del function.

  • del should check if exist in state store memory, and delete from there
  • del should delete from the database using batch
  • Add schema deleted: [{ key: string, value: Buffer }] to diff schema
  • del should save the complete diff into deleted of the diff schema if existed in DB.
  • When deleting block, it should restore the value to the database

Motivation

From the reclaim transaction, it requires the deleting of the account.

Acceptance Criteria

  • All the scenario are covered in the unit test
@sridharmeganathan sridharmeganathan added this to the Sprint 26 milestone Aug 17, 2020
@shuse2 shuse2 self-assigned this Aug 18, 2020
shuse2 added a commit that referenced this issue Aug 19, 2020
Add account del function in state store - Closes #5631
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants