Submitting a transaction with below minFee requirement gives txPool feePriority error

[mitsuaki-u]

Expected behavior

When submitting a tx with insufficient fee, Insufficient transaction fee. Minimum required fee is: ${minimumRequiredFee.toString()} should be given.

Actual behavior

Gets error: Rejecting transaction due to failed minimum entrance fee priority requirement from txPool.

This is due to txPool check happening before token module check.

Steps to reproduce

Send tx with below min fee requirement.

Which version(s) does this affect? (Environment, OS, etc...)

5.0-

[shuse2]

Possible solution

• Update lisk-chain Transaction class validate function to accept minFeePerByte and baseFees as below and check minFee requirement there (or create validateTransaction function in chain instance, which maybe more feasible)

validate( {minFeePerByte: number, baseFees: [] })

• Also add calculateMinFee = (txSize: number, minFeePerByte: number, baseFees: []) => bigint function in lisk-chain/utils/transaction.ts
• Remove minFee validation from token module
• Update usage of transaction.validate() in lisk-framework/processor