Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add lisk-js as dependency #622

Closed
toschdev opened this issue Jun 21, 2017 · 0 comments
Closed

Add lisk-js as dependency #622

toschdev opened this issue Jun 21, 2017 · 0 comments
Assignees
@diego-G

Comments

@toschdev
Copy link
Contributor

Currently Lisk-JS is listed as submodule for lisk core. Lisk-JS is used only in the lisk core tests, therefore we can get rid of it as git submodule and include it into package.json devDependencies.
This is best done when also erasing lisk-ui from the submodules.
@diego-G diego-G self-assigned this Jun 26, 2017
@diego-G diego-G added this to the Version 1.0.0 milestone Jun 26, 2017
@diego-G diego-G changed the title List lisk-js as devDependency Remove lisk-js as submodule Jun 26, 2017
@diego-G diego-G added update and removed type: test labels Jun 26, 2017
@diego-G diego-G changed the title Remove lisk-js as submodule Add lisk-js as dependency Jun 27, 2017
@karmacoma karmacoma mentioned this issue Jun 27, 2017
Merged
diego-G added a commit that referenced this issue Jun 28, 2017
@diego-G
Merge pull request #639 from LiskHQ/622-lisk-js_dependecy
a8600de 
Add lisk-js as development dependency - Closes #622
@diego-G diego-G closed this as completed Jun 28, 2017
@diego-G diego-G mentioned this issue Jul 7, 2017
Closed
@karmacoma karmacoma modified the milestone: Version 1.0.0 Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diego-G diego-G

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karmacoma @diego-G @toschdev