Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API client node info type is not matching to returned data #6603

Closed
Tracked by #6653
nazarhussain opened this issue Jul 28, 2021 · 0 comments · Fixed by #6646
Closed
Tracked by #6653

API client node info type is not matching to returned data #6603

nazarhussain opened this issue Jul 28, 2021 · 0 comments · Fixed by #6646
Assignees
@nazarhussain
Labels
elements/api-client type: bug unplanned
Milestone
Sprint 50

Comments

@nazarhussain
Copy link
Contributor

nazarhussain commented Jul 28, 2021 •
edited

Expected behavior

The client.node.getNodeInfo() must have matching type with the return value of app:getNodeInfo action.

Actual behavior

Currently genesisHeight and network attributes are missing from the type.

lisk-sdk/elements/lisk-api-client/src/types.ts

Lines 97 to 101 in 4ced142

export interface NodeInfo {
readonly version: string;
readonly networkVersion: string;
readonly networkIdentifier: string;
readonly lastBlockID: string;

Which version(s) does this affect? (Environment, OS, etc...)

5.1.x
@nazarhussain nazarhussain self-assigned this Aug 12, 2021
@nazarhussain nazarhussain mentioned this issue Aug 12, 2021
Merged
@nazarhussain nazarhussain changed the title API client node info is missing genesisHeight attribute from types API client node info type is not matching to returned data Aug 13, 2021
shuse2 added a commit that referenced this issue Aug 13, 2021
@shuse2
Merge pull request #6646 from LiskHQ/6603-update-node-info-type
98e2a5c 
API client node info type is not matching to returned data - Closes #6603
@sridharmeganathan sridharmeganathan added this to the Sprint 50 milestone Aug 15, 2021
@sridharmeganathan sridharmeganathan mentioned this issue Aug 15, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nazarhussain nazarhussain

Labels
elements/api-client type: bug unplanned
Projects
No open projects
Lisk SDK Version 6.0.0
Status: Done
Milestone
Sprint 50
Development

Successfully merging a pull request may close this issue.

API client node info type is not matching to returned data - Closes #6603 LiskHQ/lisk-sdk
2 participants
@nazarhussain @sridharmeganathan