Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On update root is saved twice on sparse merkle tree #6655

Closed
Tracked by #6653
shuse2 opened this issue Aug 16, 2021 · 1 comment · Fixed by #6663
Closed
Tracked by #6653

On update root is saved twice on sparse merkle tree #6655

shuse2 opened this issue Aug 16, 2021 · 1 comment · Fixed by #6663
Assignees
@nazarhussain
Labels
elements/tree type: bug unplanned
Milestone
Sprint 51

Comments

@shuse2
Copy link
Member

shuse2 commented Aug 16, 2021

Expected behavior

Root should be only saved once.

Actual behavior

Root is always saved twice

Steps to reproduce

Call update on sparse merkle tree and add the log for db save
@nazarhussain nazarhussain self-assigned this Aug 18, 2021
@shuse2
Copy link
Member Author

shuse2 commented Aug 18, 2021

Specifically,
https://github.com/LiskHQ/lisk-sdk/blob/development/elements/lisk-tree/src/sparse_merkle_tree/sparse_merkle_tree.ts#L168 line is not necessary since the root is handled already in https://github.com/LiskHQ/lisk-sdk/blob/development/elements/lisk-tree/src/sparse_merkle_tree/sparse_merkle_tree.ts#L162

@nazarhussain nazarhussain mentioned this issue Aug 18, 2021
Merged
ManuGowda added a commit that referenced this issue Aug 21, 2021
@ManuGowda
Merge pull request #6663 from LiskHQ/6655-smt-root
876e133 
On update root is saved twice on sparse merkle tree - Closes #6655
@sridharmeganathan sridharmeganathan added this to the Sprint 51 milestone Aug 27, 2021
@sridharmeganathan sridharmeganathan mentioned this issue Aug 28, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nazarhussain nazarhussain

Labels
elements/tree type: bug unplanned
Projects
No open projects
Lisk SDK Version 6.0.0
Status: Done
Milestone
Sprint 51
Development

Successfully merging a pull request may close this issue.

On update root is saved twice on sparse merkle tree - Closes #6655 LiskHQ/lisk-sdk
3 participants
@nazarhussain @shuse2 @sridharmeganathan