Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Forger information should be updated according to input provided #6828

Closed
ManuGowda opened this issue Oct 11, 2021 · 0 comments
Closed

Forger information should be updated according to input provided #6828

ManuGowda opened this issue Oct 11, 2021 · 0 comments

Comments

@ManuGowda
Copy link
Contributor

ManuGowda commented Oct 11, 2021

Expected behavior

Forger information should be updated according to input provided

Actual behavior

Forger info is not updated even after specifying overwrite flag

{
    "address": "6174515fa66c91bff1128913edd4e0f1de37cee0",
    "forging": true,
    "height": 39993,
    "maxHeightPrevoted": 39912,
    "maxHeightPreviouslyForged": 39907
  },

Steps to reproduce

  • Update forger info with forging:enable 6174515fa66c91bff1128913edd4e0f1de37cee0 0 0 0 --overwrite command
  • Get forger info with forging:status
  • Observe the forger info, the values are not 0
{
    "address": "6174515fa66c91bff1128913edd4e0f1de37cee0",
    "forging": true,
    "height": 39993,
    "maxHeightPrevoted": 39912,
    "maxHeightPreviouslyForged": 39907
  },

Additional Information

The following api is called when forging enable command is invoked

const result = await this._client.invoke<{ address: string; forging: boolean }>(
				'app:updateForgingStatus',
				params,
			);

Which version(s) does this affect? (Environment, OS, etc...)

Lisk SDK 5.2.0-alpha.1

@ManuGowda ManuGowda changed the title Forger info update is incorrect Forger information should be updated according to input provided Oct 11, 2021
@sridharmeganathan sridharmeganathan added this to the Sprint 55 milestone Oct 11, 2021
shuse2 added a commit that referenced this issue Oct 11, 2021
 Forger information should be updated according to input provided - Closes #6828
@shuse2 shuse2 closed this as completed Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants