Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement job function for CommitPool #6850

Closed
Tracked by #6837
ishantiw opened this issue Oct 18, 2021 · 0 comments · Fixed by #6965
Closed
Tracked by #6837

Implement job function for CommitPool #6850

ishantiw opened this issue Oct 18, 2021 · 0 comments · Fixed by #6965
Assignees
@ishantiw
Labels
framework
Milestone
Sprint 60

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Oct 18, 2021 •
edited
Loading

Description

Implement job() function of CommitPool as per specified in LIP:SingleCommit:Gossip,

  • Periodic Job Triggered every BLOCK_TIME/2, Cleans up data structures and gossips the commit messages based on condition
  • Remove stale or invalid commit messages
  • Choose commit messages according to LIP:SingleCommit:Gossip
  • Gossip commit messages by calling send() of network to 16 randomly chosen connected peers
  • Move any gossiped commit messages from _nonGossipedCommits to _gossipedCommits

Acceptance Criteria

  • Add unit test for job()
@ishantiw ishantiw mentioned this issue Oct 18, 2021
Closed
18 tasks
@shuse2 shuse2 added this to the Sprint 58 milestone Nov 19, 2021
@sridharmeganathan sridharmeganathan removed this from the Sprint 58 milestone Nov 22, 2021
@sridharmeganathan sridharmeganathan added this to the Sprint 59 milestone Dec 6, 2021
@ishantiw ishantiw self-assigned this Dec 7, 2021
@milenagojkovic milenagojkovic modified the milestones: Sprint 59, Spike 3 Dec 20, 2021
@ishantiw ishantiw mentioned this issue Dec 28, 2021
Merged
@milenagojkovic milenagojkovic modified the milestones: Spike 3, Sprint 60 Jan 3, 2022
ishantiw added a commit that referenced this issue Jan 7, 2022
@ishantiw
Merge pull request #6965 from LiskHQ/6850-implement-job-func-commitpool
bf9514d 
Implement job function for Commit Pool - Closes #6850
@shuse2 shuse2 closed this as completed Jan 7, 2022
@shuse2 shuse2 linked a pull request Jan 10, 2022 that will close this issue
Implement job function for Commit Pool - Closes #6850 #6965
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ishantiw ishantiw

Labels
framework
Projects
None yet
Milestone
Sprint 60
Development

Successfully merging a pull request may close this issue.

Implement job function for Commit Pool - Closes #6850 LiskArchive/lisk-sdk
4 participants
@shuse2 @milenagojkovic @ishantiw @sridharmeganathan