Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EventQueue interface and application config #7124

Closed
Tracked by #6950
shuse2 opened this issue Apr 22, 2022 · 0 comments · Fixed by #7157
Closed
Tracked by #6950

Update EventQueue interface and application config #7124

shuse2 opened this issue Apr 22, 2022 · 0 comments · Fixed by #7157
Assignees
Milestone

Comments

@shuse2
Copy link
Member

shuse2 commented Apr 22, 2022

Description

  • Update application config is updated to include below property. -1 would mean indefinite.
{
  system: {
    // height of the block, default is 300
    keepEventsForHeights: number,
  },
}
  • Update event queue interface to
interface EventQueue {
  add(moduleID: number, typeID: number, data: Buffer, topics?: Buffer[], noRevert?: boolean);
  // below interface should not be visible to the hook
  createSnapshot(): void;
  restoreSnapshot(): void;
}

where

  • Add function should check size of data to not exceed maximum
  • Add function should check topics has maximum length of 3, and does not contain duplicate of 0x00, 0x01 or transaction ID

Acceptance Criteria

  • Example app should be working
  • All builds and tests are passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants