Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in multisignature schema validations #744

Closed
diego-G opened this issue Aug 22, 2017 · 1 comment
Closed

Bug in multisignature schema validations #744

diego-G opened this issue Aug 22, 2017 · 1 comment
Assignees

Comments

@diego-G
Copy link

diego-G commented Aug 22, 2017

I've found several regressions/bugs related to multisignatures schema validations. Below are the expected use cases:

  • keysgroup array:
    • length between 1 and 15
    • sender not included
    • must use + operator not other
  • min integer:
    • between 2 and 16
    • always smaller than or equal to keysgroup.length + 1

In order to help to fix the issue, I've identified some bugs listed below but there might be more:

  • min should be between 2 and 16 instead of 1 and 16
  • Using another operator throws an error
  • Erroneous message Invalid multisignature min. Must be less than keysgroup size

We therefore need to revise all the validations and error messages.

karmacoma pushed a commit that referenced this issue Aug 22, 2017
Fixing verification of null member in keysgroup - Closes #744
@karmacoma
Copy link
Member

Closed by: c4eb550

@karmacoma karmacoma changed the title Regressions in multisignatures schema validations Bug in multisignature schema validations Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants