Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate usernames should be case-insensitive #8

Closed
karmacoma opened this issue Mar 21, 2016 · 2 comments
Closed

Delegate usernames should be case-insensitive #8

karmacoma opened this issue Mar 21, 2016 · 2 comments
Assignees
@karmacoma
Labels
type: bug
Milestone
Version 0.2.0

Comments

@karmacoma
Copy link
Member

Currently delegate usernames are case-insenstive, meaning for example, "MyDelegate" and "mydelegate" would result in two delegate usernames being registered. Needs to be fixed :)
@karmacoma karmacoma self-assigned this Mar 21, 2016
@karmacoma karmacoma added this to the Mainnet Launch milestone Mar 21, 2016
This was referenced Apr 30, 2016
Closed
Closed
@fix fix mentioned this issue May 10, 2016
Closed
@fix
Copy link
Contributor

fix commented May 11, 2016

to be corrected:
https://github.com/LiskHQ/lisk-cli/blob/development/helpers/block.js#L95

@fix fix mentioned this issue May 11, 2016
Merged
@mrv777
Copy link
Contributor

mrv777 commented May 11, 2016

Should you also enforce it in the database?
http://stackoverflow.com/questions/9046825/postgresql-auto-lowercase-text-while-or-before-inserting-to-a-column

karmacoma pushed a commit that referenced this issue Aug 31, 2017
Merge pull request #8 from LiskHQ/0.9.8-duplicated-delegates-names-fix
4bd9536 
Registering delegates with duplicated names fix
karmacoma pushed a commit that referenced this issue Sep 3, 2017
Revert "Merge pull request #8 from LiskHQ/0.9.8-duplicated-delegates-…
9f461b1 
…names-fix"

This reverts commit 4bd9536, reversing
changes made to 3536b69.
karmacoma pushed a commit that referenced this issue Sep 3, 2017
Merge pull request #11 from LiskHQ/0.9.9-revert-delegate-fix
9b3d85c 
Revert "Merge pull request #8 from LiskHQ/0.9.8-duplicated-delegates-names-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karmacoma karmacoma

Labels
type: bug
Projects
None yet
Milestone
Version 0.2.0
Development

No branches or pull requests
3 participants
@karmacoma @fix @mrv777