Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on total weight and certificate threshold in verifyValidatorsUpdate #9039

Closed
shuse2 opened this issue Sep 25, 2023 · 0 comments
Closed
Assignees
Milestone

Comments

@shuse2
Copy link
Member

shuse2 commented Sep 25, 2023

Expected behavior

Add additional verification logic as defined in the PR

Actual behavior

In LIP0053, in the context of posting a certificate within a CCU, we allow the new certificate threshold to be set to any value. In particular, it can be set to a value less than 1/3 of the total BFT weight or even to 0, thus allowing a following certificate to be signed by a minority of validators not satisfying the BFT requirements.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-rc-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

4 participants