Add check on total weight and certificate threshold in verifyValidatorsUpdate in LIP 0053
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricott1
commented
Sep 25, 2023
| totalWeight = 0 | ||
| for validator in newActiveValidators: | ||
| # The bftWeight property of each element is a positive integer. | ||
| if validator.bftWeight == 0: |
There was a problem hiding this comment.
This check is redundant in principle, but I kept it for symmetry with LIP0043. Let me know if you prefer to remove it
There was a problem hiding this comment.
I think it is good to have it. Otherwise, there could maybe be the case that the total weight is 0.
shuse2
approved these changes
Sep 25, 2023
gkoumout
approved these changes
Sep 25, 2023
|
Issue created: LiskHQ/lisk-sdk#9039 |
janhack
changed the title
verifyValidatorsUpdate verifyValidatorsUpdate in LIP 0053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.