Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When executeCommon fails it should fail the transaction instead of returning #9112

Closed
ishantiw opened this issue Oct 20, 2023 · 0 comments
Closed

When executeCommon fails it should fail the transaction instead of returning #9112

ishantiw opened this issue Oct 20, 2023 · 0 comments
Assignees
@ishantiw
Labels
framework/module/interoperability Interoperability module type: bug
Milestone
Sprint 106

Comments

@ishantiw
Copy link
Member

Expected behavior

According to LIP0053, if executeCommon fails then it should fail the CCU transaction

Actual behavior

if executeCommon fails then it doesn't fail the transaction but instead of that it returns without error.

Steps to reproduce

  • Send a CCU which fails at any step in executeCommon

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-rc.3
@ishantiw ishantiw self-assigned this Oct 20, 2023
ishantiw added a commit that referenced this issue Oct 20, 2023
@ishantiw
♻️ Handle ccm processing error #9100
47192ff 
- Create Panic function to exit application on unexpected error while CCU execution
- Add events to verifyPartnerChainOutboxRoot on smt and partnerOutbox failure #9111
- Rename executeCommon->beforeCrossChainMessagesExecution
- Add verifyRoutingRules similar to LIP0053
- Move verifyCertificateSignature and verifyPartnerChainOutboxRoot outside beforeCrossChainMessagesExecution and call before it #9112
- Move constant EVENT_TOPIC_CCM_EXECUTION to interoperability module
@ishantiw ishantiw mentioned this issue Oct 20, 2023
Merged
ishantiw added a commit that referenced this issue Oct 21, 2023
@ishantiw
♻️ Handle ccm processing error #9100
55143ff 
- Create Panic function to exit application on unexpected error while CCU execution
- Add events to verifyPartnerChainOutboxRoot on smt and partnerOutbox failure #9111
- Rename executeCommon->beforeCrossChainMessagesExecution
- Add verifyRoutingRules similar to LIP0053
- Move verifyCertificateSignature and verifyPartnerChainOutboxRoot outside beforeCrossChainMessagesExecution and call before it #9112
- Move constant EVENT_TOPIC_CCM_EXECUTION to interoperability module
ishantiw added a commit that referenced this issue Oct 22, 2023
@ishantiw
Update getChildQueue to replace default topic (#9110)
bf141fb 
* ♻️ Update getChildQueue to replace default topic
- getChildQueue is updated to replace default topic
- Transaction execution to have a transactionID with prefix as default topic
- CCM execution to have a ccmID with prefix as default topic

* ♻️ Add prefix to txID when call unsafeAdd

* ♻️ Handle ccm processing error #9100
- Create Panic function to exit application on unexpected error while CCU execution
- Add events to verifyPartnerChainOutboxRoot on smt and partnerOutbox failure #9111
- Rename executeCommon->beforeCrossChainMessagesExecution
- Add verifyRoutingRules similar to LIP0053
- Move verifyCertificateSignature and verifyPartnerChainOutboxRoot outside beforeCrossChainMessagesExecution and call before it #9112
- Move constant EVENT_TOPIC_CCM_EXECUTION to interoperability module

* ✅ Add and update tests for CCU execute and verifyPartnerChainOutboxRoot

* 💅🏻 Fix lint error

* 💅🏻 Apply feedback comments
@Madhulearn Madhulearn added this to the Sprint 106 milestone Oct 23, 2023
@Madhulearn Madhulearn mentioned this issue Oct 24, 2023
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishantiw ishantiw

Labels
framework/module/interoperability Interoperability module type: bug
Projects
No open projects
Lisk SDK Version 6.0.0
Status: No status
Milestone
Sprint 106
Development

No branches or pull requests
2 participants
@ishantiw @Madhulearn