Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs are not verbose enough for apply unconfirmed transaction - Fixes #1331 #1367

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
2 participants
@SargeKhan
Copy link
Member

commented Jan 23, 2018

What was the problem?

The error log for applyUnconfirmed step during applyBlock function is not correct.

How did I fix it?

Correct the log message.

How to test it?

Look at the logs.

Review checklist

  • The PR solves #1331
  • All new code is covered with unit tests
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated

@karmacoma karmacoma self-assigned this Jan 23, 2018

@karmacoma karmacoma added this to Open Issues in Version 0.9.12 via automation Jan 23, 2018

@karmacoma karmacoma added this to New Issues in Sprint Board 22-01-18 via automation Jan 23, 2018

@karmacoma karmacoma moved this from New Issues to Open PRs in Sprint Board 22-01-18 Jan 23, 2018

@karmacoma karmacoma moved this from Open Issues to Open PRs in Version 0.9.12 Jan 23, 2018

@karmacoma karmacoma merged commit 0a76924 into 0.9.12 Jan 23, 2018

Version 0.9.12 automation moved this from Open PRs to Merged PRs Jan 23, 2018

Sprint Board 22-01-18 automation moved this from Open PRs to Merged PRs Jan 23, 2018

@karmacoma karmacoma deleted the 1331-correct_logs_message branch Jan 23, 2018

@SargeKhan SargeKhan referenced this pull request Mar 5, 2018

Closed

Backport 0.9.12 changes to 1.0.0 #1666

12 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.