Add ENV variables support for few configuration option - Closes #2225 #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchavant
suggested changes
Aug 3, 2018
README.md
Outdated
| | --peers<br> -p | LISK_PEERS | peers.list | Comma separated list of peers to connect in the format `192.168.99.100:5000,172.169.99.77:5000` | | ||
| | | LISK_API_PUBLIC | api.access.public | Enable or disable public access of http API. Must be set to true/false | | ||
| | | LISK_API_WHITELIST | api.access.whiteList | Comma separated list of IPs to enable API access. Format `192.168.99.100,172.169.99.77` | | ||
| | | LISK_FORGING_DELEGATES | forging.delegates | Comma separated list of delegates to load in the format `publicKey|encryptedPassphrase,publicKey2|encryptedPassphrase2` | |
There was a problem hiding this comment.
I think you have to escape that, it does show properly in the rendered README file.
nazarhussain
force-pushed
the
2225-env-variables-support
branch
3 times, most recently
from
2882311
to
9f3db6c
Compare
nazarhussain
force-pushed
the
2225-env-variables-support
branch
from
9f3db6c
to
a11fe67
Compare
|
@fchavant Had updated the README with correct formatting. |
|
@nazarhussain it still does not show up as code but it's not mangled at least |
fchavant
approved these changes
Aug 7, 2018
|
There was a problem with |
diego-G
suggested changes
Aug 7, 2018
helpers/config.js
Outdated
| fileLogLevel: program.log || process.env.LISK_FILE_LOG_LEVEL || null, | ||
| consoleLogLevel: process.env.LISK_CONSOLE_LOG_LEVEL || null, | ||
| cacheEnabled: process.env.LISK_CACHE_ENABLED === 'true', | ||
| wsPort: +program.port || getenv(process.env.LISK_WS_PORT), |
There was a problem hiding this comment.
No this is port came from this line https://github.com/LiskHQ/lisk/blob/71ab88cdfaf06b71038e3a88644ebab5d2b1441d/helpers/config.js#L50
Didn't change command parameters for backward compatibility.
diego-G
approved these changes
Aug 7, 2018
nazarhussain
force-pushed
the
2225-env-variables-support
branch
from
b98b453
to
f888d78
Compare
ManuGowda
reviewed
Aug 8, 2018
helpers/config.js
Outdated
| address: program.address, | ||
| consoleLogLevel: program.log || process.env.LISK_CONSOLE_LOG_LEVEL, | ||
| db: { database: program.database }, | ||
| wsPort: +program.port || getenv(process.env.LISK_WS_PORT), |
There was a problem hiding this comment.
LISK_WS_PORT and LISK_HTTP_PORT should be number here?
ManuGowda
approved these changes
Aug 8, 2018
MaciejBaj
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Currently we support some subset of configuration options to be set through the ENV variables. https://github.com/LiskHQ/lisk/tree/1.1.0#command-line-options, which are not enough to run a docker image
How did I fix it?
Added further support for
ENVvariables.Review checklist