Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent informative versioning scheme - Closes #2594 #2751

Merged
merged 34 commits into from Jan 28, 2019
Merged

Use consistent informative versioning scheme - Closes #2594 #2751

merged 34 commits into from Jan 28, 2019

Conversation

2snEM6
Copy link
Contributor

@2snEM6 2snEM6 commented Jan 17, 2019

What was the problem?

There was no separation of concerns between protocol changes and implementation changes in the current versioning scheme.

For further information, please refer to LIP0007.

How did I fix it?

By implementing LIP007.

Now nodes are aware of the protocol version other peers are running on and therefore they perform compatibility checks against this version.

How to test it?

  • Run unit tests npm test -- mocha:extensive:unit
  • Run functional tests npm test --mocha:extensive:functional
  • Run network tests npm test -- mocha:default:network

Review checklist

@2snEM6
Introduce and handle protocol version information on peer headers
8fc93e0
@2snEM6
Bring back newMigration grunt task previously deleted on 388baeb
b3ad31a
@2snEM6
Update and add functional and unit tests
95e2902
@2snEM6
Add new migration to add protocolVersion column to peers table
58dcf20
@2snEM6
Add protocolVersion to peer logic and peer module
169ebba
@2snEM6
A protocolVersion to swagger schema
ea78c3d
@2snEM6
Add protocolVersion attribute to node and peer models
e3f5ab2
@2snEM6
Add protocolVersion to db get query and to peer entity
4318e3f
@2snEM6
Add and modify pertinent tests to include protocolVersion
a073017
@2snEM6
Add protocolVersion to package.json
5b8ccb9
@2snEM6
Fix handshake tests
817821f
@2snEM6
Update from main db work branch
328af56
@2snEM6
Fix test case checking for incompatible version on system headers
96d3ccb
@2snEM6
Add protocolVersion to peer fixtures
c497d85
@2snEM6
Update transport ws functional tests to include protocolVersion
82c6080
@2snEM6
Updated 'state' function to return protocolVersion information
7d282f1
@2snEM6
Update network tests to handle protocol version accordingly
b06c6c6
@2snEM6
Fix bug on GET/peers endpoint for protocolVersion filter
5b3bd3f
@2snEM6
Update functional HTTP GET tests for node and peers endpoints
1c60c70
@2snEM6
Update and improve regular expression to filter out invalid protocol …
3caaa15 
…versions, such as leading zeros and < 1.0
@2snEM6
Update protocolVersion validation on Swagger schema and system module
8c10a95
@2snEM6 2snEM6 self-assigned this Jan 17, 2019
@MaciejBaj MaciejBaj changed the title 2594 use consistent informative versioning scheme - Closes #2594 Use consistent informative versioning scheme - Closes #2594 Jan 17, 2019
@diego-G diego-G self-requested a review January 18, 2019 09:41
@2snEM6 2snEM6 force-pushed the 2594_Use_consistent_informative_versioning_scheme branch 2 times, most recently from 5ac2a26 to cc7d1ee Compare January 18, 2019 14:14
@2snEM6 2snEM6 force-pushed the 2594_Use_consistent_informative_versioning_scheme branch from cc7d1ee to 95fa2ce Compare January 18, 2019 14:16
diego-G
diego-G suggested changes Jan 18, 2019
View reviewed changes
api/ws/rpc/connect.js Show resolved Hide resolved
db/sql/migrations/updates/20190111111557_add_protocolVersion_column_to_peers.sql Outdated Show resolved Hide resolved
helpers/z_schema.js Show resolved Hide resolved
modules/peers.js Show resolved Hide resolved
modules/system.js Show resolved Hide resolved
modules/system.js Show resolved Hide resolved
test/functional/http/get/peers.js Show resolved Hide resolved
@2snEM6 2snEM6 force-pushed the 2594_Use_consistent_informative_versioning_scheme branch 2 times, most recently from 145e160 to 15978dc Compare January 21, 2019 14:58
@2snEM6 2snEM6 force-pushed the 2594_Use_consistent_informative_versioning_scheme branch from 15978dc to 4f4687c Compare January 21, 2019 15:58
@2snEM6 2snEM6 changed the base branch from feature/extensible-data-persistence-model to development January 24, 2019 08:44
diego-G
diego-G previously approved these changes Jan 25, 2019
View reviewed changes
MaciejBaj
MaciejBaj reviewed Jan 25, 2019
View reviewed changes
modules/system.js Outdated Show resolved Hide resolved
@diego-G diego-G requested a review from lsilvs January 25, 2019 13:58
@MaciejBaj MaciejBaj merged commit bd243ba into development Jan 28, 2019
@MaciejBaj MaciejBaj deleted the 2594_Use_consistent_informative_versioning_scheme branch January 28, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciejBaj MaciejBaj MaciejBaj approved these changes

@diego-G diego-G diego-G left review comments

@lsilvs lsilvs Awaiting requested review from lsilvs

Assignees

@2snEM6 2snEM6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a consistent and informative versioning scheme
4 participants
@2snEM6 @diego-G @lsilvs @MaciejBaj