Update storage entity Account to contain just getters - Closes #2764 #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only getters belongs to the shared Account entity from storage component. The rest are customised functions owned by the chain module.
nazarhussain
suggested changes
Feb 22, 2019
framework/src/modules/chain/components/storage/entities/account.js
Outdated
Show resolved
Hide resolved
framework/src/modules/chain/components/storage/entities/account.js
Outdated
Show resolved
Hide resolved
framework/src/modules/chain/components/storage/entities/account.js
Outdated
Show resolved
Hide resolved
nazarhussain
previously approved these changes
Feb 22, 2019
diego-G
force-pushed
the
2764-update_account_entity_to_contain_just_getters
branch
from
a642d63
to
674ef46
Compare
lsilvs
suggested changes
Feb 22, 2019
framework/src/modules/chain/components/storage/entities/account.js
Outdated
Show resolved
Hide resolved
lsilvs
approved these changes
Feb 25, 2019
diego-G
changed the base branch from
2767-create_entities_on_module_chain
to
development
nazarhussain
approved these changes
Feb 25, 2019
MaciejBaj
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test it?
npx mocha framework/test/mocha/unit/components/storage/entities/account.jsnpx mocha framework/test/mocha/unit/modules/chain/components/storage/entitites/account.jsReview checklist