-
Notifications
You must be signed in to change notification settings - Fork 455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just small question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good work so far.
What's missing:
helpers/index.js
is outdated and can be removed
helpers/diff.js
- maybe remove or the name should at least describe the operation on votes
helpers/transaction_types
- I think should be moved to constants
helpers/z_schema
is now duplicated with framework/src/controller/helpers/validator
, we should use the formats defined there and only import them into z_schema
@diego-G, regarding @MaciejBaj comment, let me know if you do something with |
Also, I realised that |
@shuse2 |
As discussed, please move the slot file to the |
Review checklist