This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Upgrade Node.js version from 10.14.1 to 10.15.3 - Closes #3124 #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that LiskHQ/lisk-newrelic needs to be updated also, see LiskArchive/lisk-newrelic#9. |
4miners
previously approved these changes
Mar 20, 2019
Nazgolze
previously approved these changes
Mar 20, 2019
fchavant
force-pushed
the
3124-nodejs-10.15.3
branch
from
2a1550b
to
0f6e44b
Compare
4miners
previously approved these changes
Mar 20, 2019
psychopenguin
previously approved these changes
Mar 20, 2019
Nazgolze
previously approved these changes
Mar 20, 2019
diego-G
previously approved these changes
Mar 21, 2019
MaciejBaj
changed the title
MaciejBaj
dismissed stale reviews from diego-G, Nazgolze, psychopenguin, and 4miners
via
317522b
MaciejBaj
approved these changes
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We were using Node.js version 10.14.1 while 10.15.3 is available and 10.15.2 fixes a CVE.
How did I fix it?
Set version
10.15.3in.nvmrc,package.jsonandREADME.md; updatebuild/nodejs-keyring.gpgsince new developers' keys were added.How to test it?
npm installandnpm ciworkReview checklist