This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 455
Implement pending unit tests http api module - Closes #2988 #3165
Merged
MaciejBaj
merged 10 commits into
development
from
2988-Implement_pending_unit_tests_http_api_module
Mar 25, 2019
Merged
Implement pending unit tests http api module - Closes #2988 #3165
MaciejBaj
merged 10 commits into
development
from
2988-Implement_pending_unit_tests_http_api_module
Mar 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convention restricts file names to be written only in snake case format.
shuse2
suggested changes
Mar 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! ❤️
framework/test/mocha/unit/modules/http_api/init_steps/bootstrap_cache.js
Outdated
Show resolved
Hide resolved
framework/test/mocha/unit/modules/http_api/init_steps/setup_servers.js
Outdated
Show resolved
Hide resolved
MaciejBaj
approved these changes
Mar 23, 2019
shuse2
approved these changes
Mar 23, 2019
2snEM6
approved these changes
Mar 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on this @michielmulders !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
No coverage.
How did I fix it?
Implement tests for HTTP API module.
How to test it?
Run all test suites.
Review checklist