New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the default value generation for all configurations - Closes #3273 #3288
Simplify the default value generation for all configurations - Closes #3273 #3288
Conversation
c14a2c7
to
782f341
Compare
782f341
to
261a6ed
Compare
@nazarhussain Doesn't this go against the JSON schema v7? |
No its not against JSON schema standard. We just removed the redundant default values and improved the implementation of default from root key. |
@nazarhussain I couldn't find the reference |
@shuse2 Here is the reference http://json-schema.org/latest/json-schema-validation.html#rfc.section.10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What was the problem?
There is redundant default values for nested objects due to nature of
ajv
implementation of default keyword.How did I fix it?
Added custom logic to handle default values any configuration object.
How to test it?
Run all tests
Review checklist