Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the default value generation for all configurations - Closes #3273 #3288

Merged

Conversation

nazarhussain
Copy link
Contributor

What was the problem?

There is redundant default values for nested objects due to nature of ajv implementation of default keyword.

How did I fix it?

Added custom logic to handle default values any configuration object.

How to test it?

Run all tests

Review checklist

@shuse2
Copy link
Member

shuse2 commented Apr 10, 2019

@nazarhussain Doesn't this go against the JSON schema v7?

@nazarhussain
Copy link
Contributor Author

No its not against JSON schema standard. We just removed the redundant default values and improved the implementation of default from root key.

@shuse2
Copy link
Member

shuse2 commented Apr 10, 2019

@nazarhussain I couldn't find the reference
I wasn't sure this reference applies to only object or can be in root level too
https://json-schema.org/understanding-json-schema/reference/generic.html

@nazarhussain
Copy link
Contributor Author

Copy link
Contributor

@michielmulders michielmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nazarhussain nazarhussain merged commit f778a5c into feature/improve_overall_configuration Apr 10, 2019
@nazarhussain nazarhussain deleted the 3273-default-config branch April 10, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants