Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix version reference for lisk-framework - Closes #3361 #3362

Merged
merged 7 commits into from
Apr 16, 2019
Merged

Fix version reference for lisk-framework - Closes #3361 #3362

merged 7 commits into from
Apr 16, 2019

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Apr 15, 2019

What was the problem?

lisk was referencing non-existing version

How did I fix it?

Update to use the exact same version as lisk-framework package.json

How to test it?

npm run clean:node_modules
rm -rf node_modules
npm ci

Review checklist

@shuse2 shuse2 self-assigned this Apr 15, 2019
2snEM6
2snEM6 previously approved these changes Apr 15, 2019
View reviewed changes
nazarhussain
nazarhussain suggested changes Apr 16, 2019
View reviewed changes
framework/.npmignore Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit 45eaf5c into development Apr 16, 2019
@shuse2 shuse2 deleted the 3361-fix_version_ref branch April 16, 2019 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@2snEM6 2snEM6 2snEM6 approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong reference of the version from lisk folder
3 participants
@shuse2 @nazarhussain @2snEM6