This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update jenkins after sdk merge - Closes #3350 #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Node.JS 10.x Sync commander/package-lock.json with commander/package.json
shuse2
changed the title
shuse2
previously approved these changes
Apr 16, 2019
…HQ/lisk-sdk into 3350-update_jenkins_after_sdk_merge
ManuGowda
approved these changes
Apr 16, 2019
shuse2
approved these changes
Apr 16, 2019
fchavant
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Jenkins configuration needed to be overhauled after the SDK merge.
How did I fix it?
Refactored
Jenkinsfileaccording to requirements by @shuse2 and @ManuGowdaHow to test it?
Look at
and ensure the right tests are running (some tests might need fixing outside of this PR)
Review checklist